csmock: implement --warning-rate-limit and --limit-msg-len
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kdudka
changed the title
--warning-rate-limit and --limit-msg-len
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Oct 7, 2023
... defaulting to 512 to avoid resource exhaustion on scans that go wild. Reproducer: ``` $ csmock -r rhel-7-x86_64 -f nss-util-3.90.0-1.el7_9.src.rpm -t gitleaks ``` Resolves: https://issues.redhat.com/browse/OSH-67 Closes: csutils#128
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Oct 7, 2023
... defaulting to 512 to avoid resource exhaustion on scans that go wild. Reproducer: ``` $ csmock -r rhel-7-x86_64 -f nss-util-3.90.0-1.el7_9.src.rpm -t gitleaks ``` Resolves: https://issues.redhat.com/browse/OSH-67 Closes: csutils#128
hanchuntao
reviewed
Oct 8, 2023
|
LGTM |
hanchuntao
approved these changes
Oct 9, 2023
... and initialize `embed_context` in the `ScanProps` constructor for consistency. No change in behavior intended. Related: https://issues.redhat.com/browse/OSH-67
... defaulting to 1024 to avoid resource exhaustion on scans that go wild. Related: https://issues.redhat.com/browse/OSH-67
If the `--embed-context` feature is enabled, available and successful, there should be no reason to apply results limits again. This is an optimization that should not affect the results. Related: https://issues.redhat.com/browse/OSH-67
... defaulting to 512 to avoid resource exhaustion on scans that go wild. Reproducer: ``` $ csmock -r rhel-7-x86_64 -f nss-util-3.90.0-1.el7_9.src.rpm -t gitleaks ``` Resolves: https://issues.redhat.com/browse/OSH-67 Closes: csutils#128
|
@hanchuntao Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.