results: do not duplicate important findings #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... that are tagged important by both a csmock plug-in and the scanner
itself. In a scan of gcc-toolset-12-gcc-12.2.1-7.4.el9 we had more
important findings than all findings, which does not really make any
sense:
```
% grep RESOURCE_LEAK gcc-toolset-12-gcc-12.2.1-7.4.el9/scan-results-imp-summary.txt
2 RESOURCE_LEAK error[too-many]
2046 RESOURCE_LEAK leaked_storage
756 RESOURCE_LEAK overwrite_var
% grep RESOURCE_LEAK gcc-toolset-12-gcc-12.2.1-7.4.el9/scan-results-all-summary.txt
1 RESOURCE_LEAK error[too-many]
1023 RESOURCE_LEAK leaked_storage
378 RESOURCE_LEAK overwrite_var
```
Resolves: https://issues.redhat.com/browse/OSH-466
Closes: csutils#147
hanchuntao
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that are tagged important by both a csmock plug-in and the scanner itself. In a scan of
gcc-toolset-12-gcc-12.2.1-7.4.el9we had more important findings than all findings, which does not really make any sense:Resolves: https://issues.redhat.com/browse/OSH-466