Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csmock: use NOCHECK_RPM_OPTS also for %build #176

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Jun 21, 2024

... when execution of tests is not needed for the requested scan. This fixes an unnecessary failure while SAST scanning jss-4.9.4-1.module+el8.7.0+15532+95bac9ee

Resolves: https://issues.redhat.com/browse/OSH-697
Closes: #176

... when execution of tests is not needed for the requested scan.
This fixes an unnecessary failure while SAST scanning
`jss-4.9.4-1.module+el8.7.0+15532+95bac9ee`

Resolves: https://issues.redhat.com/browse/OSH-697
Closes: csutils#176
@kdudka kdudka requested a review from jperezdealgaba June 21, 2024 11:49
@kdudka kdudka self-assigned this Jun 21, 2024
@jperezdealgaba
Copy link
Collaborator

jperezdealgaba commented Jun 21, 2024

Hey @kdudka , Regarding #175 , I assume these changes also take in consideration that if the tests are not in %build will also NOCHECK_RPM_OPTS be used , right?

@kdudka
Copy link
Member Author

kdudka commented Jun 21, 2024

@jperezdealgaba Yes, the options will always be used for %build unless a csmock plug-in (e.g. valgrind) requires tests to run or a user explicitly asks to run them via --run-check.

@jperezdealgaba
Copy link
Collaborator

Thanks! That solves my doubt. /LGTM

@kdudka
Copy link
Member Author

kdudka commented Jun 21, 2024

@jperezdealgaba Thanks for review!

@kdudka kdudka merged commit 4248148 into csutils:main Jun 21, 2024
36 checks passed
@kdudka kdudka deleted the build-without-test branch June 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants