Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devoto dev #258

Open
wants to merge 19 commits into
base: auto_MCP_DL2_DL3
Choose a base branch
from
Open

Devoto dev #258

wants to merge 19 commits into from

Conversation

FedericoDevoto757
Copy link
Collaborator

Adding two semiautomatic scripts to create DL2 and DL3 files, currently the scripts are not working properly, I'm working on a solution with Elisa.

@Elisa-Visentin Elisa-Visentin marked this pull request as draft September 13, 2024 10:49
@Elisa-Visentin Elisa-Visentin marked this pull request as draft September 13, 2024 10:49
@Elisa-Visentin
Copy link
Collaborator

I put it in draft to prevent accidental merges. In the meanwhile I will start checking it then we can ask Julian and Alessio for a review :)

Copy link
Collaborator

@Elisa-Visentin Elisa-Visentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started checking the first script, so that we can improve it and adapt it to the previous ones

@Elisa-Visentin
Copy link
Collaborator

@aleberti, @jsitarek: with these steps we introduce some new 'hyper-parameters': available MC_dec, MAGIC periods (+dates), [available lstchain version (already in v0.5)]...: should we add it to config_auto_MCP, or should we create a new configuration file, stored somewhere? (where?)

@aleberti
Copy link
Collaborator

I would add them to the already available configuration file, since they are in any case still related to the semi-automatic scripts.

@Elisa-Visentin
Copy link
Collaborator

Ok, so maybe I will organize a bit differently the config file, just to separate things that must 'always' be updated and parameters that you usually should not change (to prevent strange errors)

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (40bb433) to head (20902b7).
Report is 10 commits behind head on auto_MCP_DL2_DL3.

Additional details and impacted files
@@                Coverage Diff                @@
##           auto_MCP_DL2_DL3     #258   +/-   ##
=================================================
  Coverage             77.23%   77.23%           
=================================================
  Files                    21       21           
  Lines                  2614     2614           
=================================================
  Hits                   2019     2019           
  Misses                  595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Elisa-Visentin
Copy link
Collaborator

Ongoing tests (on the IT); in the meantime: major changes? Requests? Comments?

@Elisa-Visentin Elisa-Visentin marked this pull request as ready for review November 27, 2024 14:10
@Elisa-Visentin
Copy link
Collaborator

Elisa-Visentin commented Nov 28, 2024

  • glo-dyn
  • in-out v
  • chech ra dec dec_mc not nan
  • move ST*.txt in out folder
  • check job accounting
  • check printed values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants