-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devoto dev #258
base: auto_MCP_DL2_DL3
Are you sure you want to change the base?
Devoto dev #258
Conversation
I put it in draft to prevent accidental merges. In the meanwhile I will start checking it then we can ask Julian and Alessio for a review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started checking the first script, so that we can improve it and adapt it to the previous ones
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL1_to_DL2.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/new_nsb_DL2_to_DL3.py
Outdated
Show resolved
Hide resolved
I would add them to the already available configuration file, since they are in any case still related to the semi-automatic scripts. |
Ok, so maybe I will organize a bit differently the config file, just to separate things that must 'always' be updated and parameters that you usually should not change (to prevent strange errors) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## auto_MCP_DL2_DL3 #258 +/- ##
=================================================
Coverage 77.23% 77.23%
=================================================
Files 21 21
Lines 2614 2614
=================================================
Hits 2019 2019
Misses 595 595 ☔ View full report in Codecov by Sentry. |
Ongoing tests (on the IT); in the meantime: major changes? Requests? Comments? |
|
Adding two semiautomatic scripts to create DL2 and DL3 files, currently the scripts are not working properly, I'm working on a solution with Elisa.