Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a function to create a log file and save cloud correction para… #260

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Adding a function to create a log file and save cloud correction para… #260

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b55522
Adding a function to create a log file and save cloud correction para…
nzywucka Sep 13, 2024
ba5ed61
Saving parameters to the .log file simplified and saving the .h5 file…
nzywucka Sep 16, 2024
e0ce62d
Provided changes in check of the available images in the .h5 files, l…
nzywucka Oct 1, 2024
bd16f73
config.yaml: the cloud_correction section has been changed
nzywucka Oct 29, 2024
edb06c7
Rename file to correct name
nzywucka Nov 4, 2024
7d24ab2
Removed filename from the repository
nzywucka Dec 5, 2024
8047de9
config.yaml: stereo reco quality cut has been changed to the orginal.
nzywucka Dec 5, 2024
11041ed
config.yaml: additional cleaning LST and MAGIC parameters added
nzywucka Dec 5, 2024
d213c9b
config.yaml: modification of the cloud_correction section
nzywucka Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions magicctapipe/resources/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,22 @@ dl2_to_dl3:
source_dec: null # used when the source name cannot be resolved

cloud_correction:
specify_cloud: yes
base_height: "5900. m"
thickness: "1320. m"
vertical_transmission: 1.0
max_gap_lidar_shots: "900 s"
lidar_report_file: "../../resources/lidar_reports_clouds_ST.03.16.yaml"
number_of_layers: 10

additional_lst_cleaning:
picture_thresh: 10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the purpose of redoing the cleaning is to raise the thresholds by some factor, and the same factor should be applied to LST and MAGIC. So, either the factor is determined automatically in the script (but this can be messy because then one needs to process the simulations for each run even if changes are small, or you specify in the input card only a single multiplication factor and this factor is applied to picture_thresh, boundary_thresh of both MAGIC and LST, and rest of the settings should be taken from default config or from the file itself (at least for MAGIC, because for LST this can be more tricky)

boundary_thresh: 5
keep_isolated_pixels: false
min_number_picture_neighbors: 2

additional_magic_cleaning:
use_time: true
use_sum: true
picture_thresh: 6
boundary_thresh: 3.5
max_time_off: 4.5
max_time_diff: 1.5
find_hotpixels: false
pedestal_type: "from_extractor_rndm"
Loading
Loading