Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some enhancements for the DQM #101

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Some enhancements for the DQM #101

merged 2 commits into from
Feb 1, 2024

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Feb 1, 2024

This PR:

@jlenain
Some enhancements in the DQM:
bf4f033 
- add an event meter when looping over events
- add an option on maximum number of events to loop on for each run slice
- add an option to disable all R0->R1 corrections
@jlenain
Remove plot legens when unnecessary
3acb625
@jlenain jlenain requested a review from hashkar February 1, 2024 12:45
@jlenain jlenain self-assigned this Feb 1, 2024
@jlenain jlenain added bug Something isn't working enhancement New feature or request labels Feb 1, 2024
@jlenain jlenain linked an issue Feb 1, 2024 that may be closed by this pull request
Wrong input path in DQM when automagically fetching runs from DIRAC #96
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d062d8e) 30.82% compared to head (3acb625) 30.92%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/nectarchain/dqm/start_dqm.py 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   30.82%   30.92%   +0.10%     
==========================================
  Files          60       60              
  Lines        3767     3754      -13     
==========================================
  Hits         1161     1161              
+ Misses       2606     2593      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain requested review from dkerszberg and removed request for hashkar February 1, 2024 12:48
@jlenain jlenain linked an issue Feb 1, 2024 that may be closed by this pull request
DQM failing for single-gain runs #64
Closed
@jlenain jlenain mentioned this pull request Feb 1, 2024
Closed
@jlenain jlenain merged commit 1f3397c into cta-observatory:master Feb 1, 2024
11 of 12 checks passed
@jlenain jlenain deleted the dqm branch February 1, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkerszberg dkerszberg dkerszberg approved these changes

Assignees

@jlenain jlenain

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong input path in DQM when automagically fetching runs from DIRAC DQM failing for single-gain runs
2 participants
@jlenain @dkerszberg