Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement scanner #147

Merged
merged 7 commits into from
May 7, 2024
Merged

feat: implement scanner #147

merged 7 commits into from
May 7, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Apr 5, 2024

Original (#141)

Authors: @jessieh9 @KevinWu098

What does this PR contain?

  1. Implemented Scanner component as described in Generate QR Code For Volunteer ID Util + Implement Scanner Functionality #141
  2. Added a "Success Button" in lieu of generating an actual QR code and handling a yet-to-be-determined url format.

How did you test these changes?

  1. Go to /checkin/XX
  2. Click Scan button
  3. See CheckinModal

Attach images (if applicable)

chrome-capture-2024-3-5

Closes #141

Update (#181)

Authors: @Jaslavie @KevinWu098

Within Scanner, after scanning a QR code, it will display the scanned text data as the plain volunteer id

  • Accepts a QR code with a text body following this schema:
interface QRCodeData {
  first_name: string;
  last_name: string;
  id: number;
}
  • Handles errors accordingly

Refactor handleScannerSuccess to adjust the format of the volunteer object passed in

  • Adds in number_in_party to volunteer object

When CheckinModal is submitted... the volunteer... should be checked-in and... the value of number_in_party updated

Co-authored-by: Jessie He <[email protected]>
@KevinWu098 KevinWu098 requested review from Aokijiop and NwinNwin April 5, 2024 23:15
@KevinWu098
Copy link
Member Author

@NwinNwin @Aokijiop PR is ready for re-review a la #181

KevinWu098 and others added 2 commits May 2, 2024 02:12
…played. Fixed issue relating to checkin via table method not working. Fixed issue relating to checkin via scanner method not closing the modal.
@Aokijiop Aokijiop merged commit a1d1676 into main May 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate QR Code For Volunteer ID Util + Implement Scanner Functionality
2 participants