Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PastEvents Page + PastEvent Page #148

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

brelieu05
Copy link
Collaborator

Authors:
brelieu05, tig-github

What does this PR contain?
Matched Hi-Fi Design for PastEvents Pages.

How did you test these changes?
Compared with Figma to see if implemented code closely matches the design (Table, Total Registered, Total Checked-In Volunteers, Button, Table, etc.).

Closes #139

@brelieu05 brelieu05 requested review from Aokijiop and NwinNwin April 6, 2024 01:38
@brelieu05 brelieu05 linked an issue Apr 6, 2024 that may be closed by this pull request
src/pages/PastEvents.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@Aokijiop Aokijiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good guys! Made some small adjustments to the backend to use the new past_events view and adjusted the frontend accordingly.

@Aokijiop Aokijiop merged commit b8f86fe into main Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PastEvents Page + PastEvent Page
4 participants