Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: volunteer profile mobile view + volunteer side view #149

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

stevem-zhou
Copy link
Collaborator

Authors: @KatyH820 @stevem-zhou

What does this PR contain?

Created the mobile view for the profile page, as well as the new volunteer side view.

How did you test these changes?

The component is able to show information of the specified event via eventId that's passed in. Checked mobile view through the chrome dev tools, setting it on iphone se.

Attach images (if applicable)

Closes #144

@stevem-zhou stevem-zhou changed the title finished mobile view and new volunteer mobile view feat: volunteer profile mobile view + volunteer side view Apr 7, 2024

useEffect(() => {
getEventById(eventId).then(data => setEventData(data));
}, []);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has a missing dependency: 'eventId'. Either include it or remove the dependency array.

@stevem-zhou stevem-zhou requested review from Aokijiop and NwinNwin April 7, 2024 01:59
Copy link
Collaborator

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WW Crud lovers

@NwinNwin NwinNwin merged commit ac4e8a8 into main Apr 9, 2024
3 checks passed
@NwinNwin NwinNwin deleted the 144-volunteer-mobile-view-profile-page-+-side-view branch April 9, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer - Mobile View Profile Page + Side View
3 participants