Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

151 implement volunteer side home page #163

Merged
merged 11 commits into from
Apr 17, 2024

Conversation

theNatePi
Copy link
Collaborator

@theNatePi theNatePi commented Apr 15, 2024

Changes

Volunteer Home Page

  • Copied admin functionality onto volunteer-home route
  • Removed selection and archiving functionality
  • Maintained Search Location and Search Date functionality although it was not in design (I believe we talked about keeping this included before)
  • Slightly change EventCard to match design on Figma
  • Implement hamburger menu
image image

Impact Summary

  • Implemented Impact Summary and proper icons
  • Updated DataCard to match design
image

Testing

  • Added line in VolunteerImpactSummary.jsx to set user ID to 111, this user has available events for testing values
    • image
  • Implemented check for isNaN(largestItem) || !isFinite(largestItem) if provided weights are empty or invalid

@theNatePi theNatePi linked an issue Apr 15, 2024 that may be closed by this pull request
@theNatePi theNatePi requested review from Aokijiop and NwinNwin April 15, 2024 04:40
updateUser();
console.log(user);
getData();
}, []);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has missing dependencies: 'getData', 'updateUser', and 'user'. Either include them or remove the dependency array.

} else result = events;
console.log(result);
setDisplayEvents(result);
}, [name, location, date, fuse]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has a missing dependency: 'events'. Either include it or remove the dependency array.

I forgot to do this initially, match design by adding 'lbs' next to the Total Trash Weight and Largest Trash Item Collected
Copy link
Collaborator

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tech lead

@NwinNwin NwinNwin merged commit abeee6c into main Apr 17, 2024
2 checks passed
@NwinNwin NwinNwin deleted the 151-implement-volunteer-side-home-page branch April 17, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Volunteer side Home Page
4 participants