Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

178 volunteer events page side view mobile bug #183

Merged
merged 8 commits into from
May 6, 2024

Conversation

farahnazhoque
Copy link
Collaborator

No description provided.

@farahnazhoque farahnazhoque linked an issue Apr 28, 2024 that may be closed by this pull request
Copy link
Collaborator

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you for submitting the PR. However, there are some flaws in the desktop view in your PR

  • image
  • Sorry for the misunderstanding but for this sprint, we want only use the drawer when the our site is in the iPhone View

  • When in Desktop View, we want to still keep the tab implementation (like below)

    • image

Recommendations:

First Step:

  • In order to address the issue effectively, it is recommended to carefully review the problem and create a new component named VolunteerSideViewDrawer. This new component should encapsulate the ChakraUI Drawer components, rather than making modifications to the existing VolunteerSideView component.
  • The VolunteerSideViewDrawer component should receive isOpen, onClose, and onOpen props from VolunteerEventPage.jsx.

Second Step:

  • Ensure that VolunteerEventPage does not directly import any Drawer components from ChakraUI. These imports should be handled within the VolunteerSideViewDrawer component.
  • VolunteerEventPage should solely import and utilize useDisclosure for managing the drawer's opening status.

Third Step:

  • Leverage ChakraUI Breakpoints to conditionally display either the VolunteerSideView or VolunteerSideViewDrawer components based on the screen size.
  • When incorporating ChakraUI breakpoints, remember to utilize md for mobile screen sizes to ensure a responsive design.

@farahnazhoque farahnazhoque force-pushed the 178-volunteer-events-page-side-view-mobile-bug branch from a804cc9 to 8563196 Compare May 1, 2024 20:47
@eachen1010 eachen1010 requested a review from NwinNwin May 2, 2024 15:04
Copy link
Collaborator

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the requested changes ;)))

@NwinNwin NwinNwin merged commit f278fb0 into main May 6, 2024
2 of 3 checks passed
@NwinNwin NwinNwin deleted the 178-volunteer-events-page-side-view-mobile-bug branch May 6, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer Events Page Side View Mobile Bug
3 participants