-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
178 volunteer events page side view mobile bug #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, Thank you for submitting the PR. However, there are some flaws in the desktop view in your PR
-
Sorry for the misunderstanding but for this sprint, we want only use the drawer when the our site is in the
iPhone View
-
When in
Desktop View
, we want to still keep the tab implementation (like below)
Recommendations:
First Step:
- In order to address the issue effectively, it is recommended to carefully review the problem and create a new component named
VolunteerSideViewDrawer
. This new component should encapsulate the ChakraUI Drawer components, rather than making modifications to the existingVolunteerSideView
component. - The
VolunteerSideViewDrawer
component should receiveisOpen
,onClose
, andonOpen
props fromVolunteerEventPage.jsx
.
Second Step:
- Ensure that
VolunteerEventPage
does not directly import any Drawer components from ChakraUI. These imports should be handled within theVolunteerSideViewDrawer
component. VolunteerEventPage
should solely import and utilizeuseDisclosure
for managing the drawer's opening status.
Third Step:
- Leverage ChakraUI Breakpoints to conditionally display either the
VolunteerSideView
orVolunteerSideViewDrawer
components based on the screen size. - When incorporating ChakraUI breakpoints, remember to utilize
md
for mobile screen sizes to ensure a responsive design.
a804cc9
to
8563196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the requested changes ;)))
No description provided.