Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Link Firebase Authentication to Volunteers Table #35

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

phillipcutter
Copy link
Contributor

Authors: @phillipcutter @KatyH820

What does this PR contain?

  1. Added first & last name fields to the create account form, along with validation requiring the fields be entered
  2. Added a POST call to /profiles to create a new volunteer record when a user creates their account
    • Note that only the email, first name, and last name are passed. The email is used as the primary key (ID).

How did you test these changes?

We tested these changes by running the backend locally, and tested creating an account without a first and/or last name to ensure validation worked, then ensured the /profiles endpoint was being called to create a new volunteer record in the database when a user creates an account.

Attach images (if applicable)

New create account form:
image

No first name filled out:
image

No last name filled out:
image

Closes #30

@phillipcutter
Copy link
Contributor Author

Looks like CI is failing because this commit added react-pdf, which requires node>=18, but the CI is pinned to 16 here:
https://github.com/ctc-uci/stand-up-to-trash-frontend/blob/main/.github/workflows/CI.yml#L15

Should we adjust the dependency or update the CI pipeline to handle this?

Copy link
Collaborator

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank youu guyss <3

@NwinNwin NwinNwin merged commit 389fbbc into main Jan 31, 2024
1 of 5 checks passed
@NwinNwin NwinNwin deleted the 30-link-firebase-authentication-to-volunteers-table branch February 20, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link Firebase Authentication to Volunteers Table
3 participants