Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have overhauled the French translation. I have not verified exactly but it should now be 100% complete.
It seems that quite a lot of percent characters were missing, such as
%f
,%n
, etc. There were a couple of translations that were completely wrong probably due to copy-pasteWhat is difficult in French, is that an unbreakable space is needed before certain characters such as ":", "?", "!", etc. You will see that a lot of strings end with an unbreakable space in the French translation contrary to the English string. This is because the ":" character seems to be added later in the C++ code. It would be nice if DCP-o-matic the ":" character in the translatable string instead.
It is not always clear if English words such as "Read" are past participles such as in "this e-mail has been read" or infinitive verbs such as in "please read this e-mail". It would be nice to have a comment in the translation to differentiate these two cases.
For
dcp_content_type.cc
, it would be nice to mention https://registry-page.isdcf.com/contenttypes/ to better understand the types. Most translations do not seem to bother translating them and the Polish translation falls back to showing FTR, TLR, TSR, etc.