Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidperrenoud
Copy link

I have overhauled the French translation. I have not verified exactly but it should now be 100% complete.

It seems that quite a lot of percent characters were missing, such as %f, %n, etc. There were a couple of translations that were completely wrong probably due to copy-paste

What is difficult in French, is that an unbreakable space is needed before certain characters such as ":", "?", "!", etc. You will see that a lot of strings end with an unbreakable space in the French translation contrary to the English string. This is because the ":" character seems to be added later in the C++ code. It would be nice if DCP-o-matic the ":" character in the translatable string instead.

It is not always clear if English words such as "Read" are past participles such as in "this e-mail has been read" or infinitive verbs such as in "please read this e-mail". It would be nice to have a comment in the translation to differentiate these two cases.

For dcp_content_type.cc, it would be nice to mention https://registry-page.isdcf.com/contenttypes/ to better understand the types. Most translations do not seem to bother translating them and the Polish translation falls back to showing FTR, TLR, TSR, etc.

@cth103
Copy link
Owner

cth103 commented Nov 15, 2022

Wow, this is amazing! Thank you!

Maybe I should merge this and then we can think about your questions? Or would you prefer to clarify things before merging?

@davidperrenoud
Copy link
Author

We can merge it. :)

@cth103
Copy link
Owner

cth103 commented Nov 15, 2022

I squashed the two commits and merged, thank you!

@cth103
Copy link
Owner

cth103 commented Nov 15, 2022

What is difficult in French, is that an unbreakable space is needed before certain characters such as ":", "?", "!", etc. You will see that a lot of strings end with an unbreakable space in the French translation contrary to the English string. This is because the ":" character seems to be added later in the C++ code. It would be nice if DCP-o-matic the ":" character in the translatable string instead.

This is a little tricky, as the presence of the : in some cases is platform dependent (for labels it's added on macOS, where this seems to be the standard, but not on Windows or Linux).

I guess we could do this the other way around: the translatable strings have a : and we remove it for labels on Linux/Windows. That would require a bit of effort to update existing translations.

It is not always clear if English words such as "Read" are past participles such as in "this e-mail has been read" or infinitive verbs such as in "please read this e-mail". It would be nice to have a comment in the translation to differentiate these two cases.

Do you have any note of confusing phrases that you found? It's no problem to add clarifying comments.

For dcp_content_type.cc, it would be nice to mention https://registry-page.isdcf.com/contenttypes/ to better understand the types. Most translations do not seem to bother translating them and the Polish translation falls back to showing FTR, TLR, TSR, etc.

Nice idea, I added a link in 3476d67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants