-
Notifications
You must be signed in to change notification settings - Fork 149
Unifies all posts on a single table #171
base: master
Are you sure you want to change the base?
Conversation
Makes the post function write to the posts table instead of the posts_%s table.
index(), thread_find_page() and getPages()
May Allah (peace be upon him) have mercy on my soul.
@ctrlcctrlv, I'm afraid that the new install.php might take too long and timeout. What can be done about it? |
@@ -1766,7 +1796,7 @@ function markup(&$body, $track_cites = false) { | |||
} | |||
$search_cites = array_unique($search_cites); | |||
|
|||
$query = query(sprintf('SELECT `thread`, `id` FROM ``posts_%s`` WHERE ' . | |||
$query = query(sprintf('SELECT `thread`, `id` FROM ``posts`` WHERE `board` = "%s" ' . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprintf -> prepare
Thanks for the comments, @czaks! I was a bit cautious when changing sprintfs that weren't used just for |
Also, other changes requested by czaks.
@czaks, I've made most of the changes you've requested. I'm not sure about how to do the remaining changes in In ukko, I've made a change to how the threads are selected. Instead of:
I've decided that this may be more efficient:
Also, is it okay to do a |
@czaks, two points that I've discussed with @Lineark:
We would be including the secret boards in this count, but it would be fast.
What do you prefer? |
Thanks @czaks and @ctrlcctrlv for all the help.
I think this is done. Unfortunately I have taken too long to do this so I think it diverges a little bit from the current code. I'll do a merge and review the conflicts.