Update registry logger output and format #57
Conversation
WalkthroughThe recent update enhances the logging system by incorporating the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- internal/pkg/beskar/registry.go (2 hunks)
Additional comments not posted (3)
internal/pkg/beskar/registry.go (3)
17-17: Import ofospackage is appropriate for the new logging functionality.
99-99: Logger field correctly added to theRegistrystruct and initialized.
94-97: Logger initialization updated to output JSON formatted logs to stdout.Verification successful
The verification confirms that the logger instance in
internal/pkg/beskar/registry.gois correctly configured to use JSON formatting. No other logger instances or configurations were found that contradict this setup.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all logger instances in the application are updated to use JSON formatting. # Test: Search for logger instances not using JSONFormatter. Expect: No occurrences. rg --type go $'logrus.New()'Length of output: 29
Script:
#!/bin/bash # Description: Verify that all logger instances in the application are updated to use JSON formatting. # Test: Search for logger instances and their configurations. Expect: All instances should use JSONFormatter. rg --type go 'logrus\.' | grep -E 'SetFormatter|New'Length of output: 132
|
Closing this one. We can override this client side. No need to change the default formatter |
This change updates the registry's logger to output logs in JSON on stdout. This makes it easier for logging/monitoring tools to ingest and correctly categorize beskar logs.
Summary by CodeRabbit