Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial review for el9 aarch64 shim submission #4

Open
wants to merge 43 commits into
base: aarch_15.8_el9
Choose a base branch
from

Conversation

jason-rodri
Copy link
Contributor

WIP, will comment on items needing work
Will tag on items needing review

skip77 and others added 30 commits October 19, 2022 18:04
Updating README.md with review comments
15.8 submission

* updating the Readme to reflect the sbat in the binary

* updating grub sbat

* adding cert in shim to review

* adding der to review

* updating sbat

* adding mock build logs


Approved-by: Jonathan Maple
Sub prep

* updating for EL9

* updating sub

* removing ref to ia32

* using vault as static repos

* updating with sbat info

* adding shim hash

* updating log

* removing ai32 take 2

* updating build log

* removing concept of siging grub/kernel with different certs


Approved-by: Skip Grube
Initial release is based off Rocky 9.2 (long term support)

Correcting earlier commit.

-Skip G.
Dockerfile Outdated Show resolved Hide resolved
ciq_static_shim.repo Outdated Show resolved Hide resolved
@jason-rodri jason-rodri self-assigned this Jan 2, 2025
@jason-rodri jason-rodri marked this pull request as ready for review January 2, 2025 23:12
@josephtate
Copy link

This is for all of CIQ's 9.x work, right? not just LTS 9.2?

@elguero
Copy link

elguero commented Jan 3, 2025

This is for all of CIQ's 9.x work, right? not just LTS 9.2?

That is correct. The SHIM can be used with all of 9.x.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@josephtate josephtate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some questions that made me scratch my head.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@josephtate josephtate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any other concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants