Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update imageMapster.js #78

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update imageMapster.js #78

wants to merge 2 commits into from

Conversation

dhinostroza
Copy link

Second try

@pbchase pbchase requested a review from saipavan10-git June 11, 2024 18:28
@saipavan10-git saipavan10-git changed the base branch from master to develop June 12, 2024 14:46
saipavan10-git
saipavan10-git previously approved these changes Jun 12, 2024
View reviewed changes
Copy link

@saipavan10-git saipavan10-git left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security scanner shows no problems, as the PSALM no longer complains about javascript eval()(Mentioned by @ChemiKyle on #71 ).

image

Upon further inspection of the change, I noticed that eval() was still used in the imageMapster.js

image

@dhinostroza, could you please make the necessary changes to remove or replace eval()?

@pbchase The issue we had yesterday was because the PR branch did not have the latest changes from develop, this has been resolved with a merge commit.

@saipavan10-git saipavan10-git self-requested a review June 12, 2024 18:24
@saipavan10-git saipavan10-git dismissed their stale review June 12, 2024 18:29

re-reviewing the change

saipavan10-git
saipavan10-git requested changes Jun 12, 2024
View reviewed changes
Copy link

@saipavan10-git saipavan10-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes. Please take a look at the above comment.

@dhinostroza
Copy link
Author

dhinostroza commented Jun 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saipavan10-git saipavan10-git saipavan10-git requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhinostroza @saipavan10-git