Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPError handling for API and Send-It tests #93

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

try:
from urllib.request import urlopen # Python3
from urllib.error import HTTPError
except ImportError:
# TODO: deprecate Python2 support entirely
from urllib2 import urlopen # Python2

class Weburl():
Expand Down Expand Up @@ -68,14 +70,22 @@ def testRouteToSendItController(self):
localpath = "index.php?route=SendItController:download&abcdef"
self.fullpath=self.redcap_root + self.redcap_version_path + localpath
expected_string = 'Send-It:'
self.assertIn(expected_string, self.weburl.get(self.fullpath, True))
try:
response_string = self.weburl.get(self.fullpath, True)
except HTTPError:
response_string = ""
self.assertIn(expected_string, response_string)

def testApiFolder(self):
"""Verify that we can access the REDCap api/ folder"""
localpath = "api/"
self.fullpath=self.redcap_root + localpath
expected_string = 'The requested method is not implemented.'
self.assertIn(expected_string, self.weburl.get(self.fullpath))
try:
response_string = self.weburl.get(self.fullpath)
except HTTPError:
response_string = ""
self.assertIn(expected_string, response_string)

# deactivate the API Help tests as they are failing routinely in Shib and probably not relevant.
# def testApiHelpFolder(self):
Expand Down