Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objects_to_include param to unnest_job_summary_data_json_object() #115

Conversation

pbchase
Copy link
Contributor

@pbchase pbchase commented Jun 2, 2023

Addresses Issue #112 and #113.

@pbchase pbchase marked this pull request as ready for review October 24, 2023 16:45
@pbchase
Copy link
Contributor Author

pbchase commented Nov 16, 2023

@ChemiKyle, this PR is getting lonely. It is very sad.

So is @emilyolsen246 , 'cause she needs it. :-(

@ChemiKyle
Copy link
Contributor

I was holding off on merging this because it has the strange issue in vignettes of complaining about dependencies despite them being called with library.

checking for unstated dependencies in vignettes ... NOTE
  '::' or ':::' imports not declared from:dotenv’ ‘here'library' or 'require' calls not declared from:kableExtra’ ‘tidyverse

I'll just merge since it's blocking now and I'm not pedantic enough to consider a warning in a vignette that important.

@ChemiKyle ChemiKyle merged commit d6c74dd into ctsit:develop Nov 17, 2023
1 check passed
@pbchase
Copy link
Contributor Author

pbchase commented Nov 17, 2023

I was holding off on merging this because it has the strange issue in vignettes of complaining about dependencies despite them being called with library.

@ChemiKyle, you were right to be concerned. The vignette would not build in Github CI. I am already working on #142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants