Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project and instance fields to rcc job log #160

Merged

Conversation

ljwoodley
Copy link
Contributor

@ljwoodley ljwoodley commented Jun 3, 2024

Closes issue #159.

Here's the alter table statement to update rcc_job_log

ALTER TABLE `rcc_job_log`
ADD COLUMN `project` VARCHAR(128) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL AFTER `log_date`,
ADD COLUMN `instance` VARCHAR(128) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL AFTER `project`;

ALTER TABLE `rcc_job_log`
ADD INDEX `project` (`project`),
ADD INDEX `instance` (`instance`);

note there was one unrelated error when testing the build. This will be resolved in another PR.

Copy link
Contributor

@saipavan10-git saipavan10-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Reviewed and tested the new features using a script with init_etl() function. The log database now includes the project name and instance details

@pbchase
Copy link
Contributor

pbchase commented Jun 13, 2024

This looks good the documentation and templates need a little updating, but the functionality is great. The code is robust in sloppy deployments.

@pbchase pbchase merged commit 3eb814f into ctsit:develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants