Skip to content

Commit

Permalink
refactor: Removed MetadataCacheFactory::build_writer_props
Browse files Browse the repository at this point in the history
  • Loading branch information
srh authored Sep 30, 2024
1 parent 7e93511 commit c29478e
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions datafusion/src/physical_plan/parquet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ use arrow::{
};
use hashbrown::HashMap;
use log::debug;
use parquet::file::properties::{WriterProperties, WriterPropertiesBuilder};
use parquet::file::{
footer,
metadata::RowGroupMetaData,
Expand Down Expand Up @@ -141,7 +140,6 @@ pub trait ParquetMetadataCache: Debug + Sync + Send {
}
}

// TODO: Rename to ParquetMetadataCacheFactory? Rename for build_writer_props field?
/// Constructs the desired types of caches for Parquet Metadata.
pub trait MetadataCacheFactory: Sync + Send {
/// Makes a noop cache (which doesn't cache)
Expand All @@ -152,13 +150,6 @@ pub trait MetadataCacheFactory: Sync + Send {
max_capacity: u64,
time_to_idle: Duration,
) -> Arc<dyn ParquetMetadataCache>;
/// Modifies and builds writer properties.
fn build_writer_props(
&self,
builder: WriterPropertiesBuilder,
) -> Result<WriterProperties> {
Ok(builder.build())
}
}

/// Default MetadataCache, does not cache anything
Expand Down

0 comments on commit c29478e

Please sign in to comment.