feat: add ParquetEncryptionMode, to permit unencrypted files in initial key rotation #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSDaemon
reviewed
Sep 11, 2024
parquet/src/file/encryption.rs
Outdated
| Unencrypted, | ||
| /// Means the file is footer-encrypted -- well, fully-encrypted. The same key is used for all | ||
| /// the columns too, in this implementation. | ||
| FooterEncrypted(ParquetEncryptionKeyInfo), |
There was a problem hiding this comment.
emm, if it is fully encrypted — maybe it should be named similarly? Cause now it's a bit contractionary, nope?
There was a problem hiding this comment.
Maybe it should be called EncryptedFooter -- because it's referring to the parquet encryption spec "encrypted footer mode", as opposed to plaintext footer mode. Every encrypted file (under the parquet encryption spec as well as our code) is "fully" encrypted, except for the footer in plaintext encryption mode, and except for the key metadata block.
There was a problem hiding this comment.
and the comment could be less confusing too.
srh
force-pushed
the
parquet-optional-read-key
branch
from
1a425b3
to
04f21c3
Compare
paveltiunov
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So now read key sets can be
[Unencrypted, key1, key2]when starting out.