Skip to content

Commit

Permalink
remove dep on @google-cloud/storage in Databricks for export bucket flow
Browse files Browse the repository at this point in the history
  • Loading branch information
KSDaemon committed Sep 25, 2024
1 parent 2ec068f commit 1485b9d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
1 change: 0 additions & 1 deletion packages/cubejs-snowflake-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"dependencies": {
"@cubejs-backend/base-driver": "^0.36.0",
"@cubejs-backend/shared": "^0.36.0",
"@google-cloud/storage": "^5.8.5",
"date-fns-timezone": "^0.1.4",
"snowflake-sdk": "^1.13.1"
},
Expand Down
10 changes: 1 addition & 9 deletions packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
DriverCapabilities,
} from '@cubejs-backend/base-driver';
import { formatToTimeZone } from 'date-fns-timezone';
import { Storage } from '@google-cloud/storage';
import { HydrationMap, HydrationStream } from './HydrationStream';

// eslint-disable-next-line import/order
Expand Down Expand Up @@ -643,14 +642,7 @@ export class SnowflakeDriver extends BaseDriver implements DriverInterface {
const { credentials } = (
<SnowflakeDriverExportGCS> this.config.exportBucket
);
return this.extractFilesFromGCS(
new Storage({
credentials,
projectId: credentials.project_id
}),
bucketName,
tableName,
);
return this.extractFilesFromGCS({ credentials }, bucketName, tableName);
} else if (bucketType === 'azure') {
const { azureKey, sasToken } = (
<SnowflakeDriverExportAzure> this.config.exportBucket
Expand Down

0 comments on commit 1485b9d

Please sign in to comment.