Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): PowerBI contains filter support #4646

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jun 1, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

#3906

@paveltiunov paveltiunov requested review from a team as code owners June 1, 2022 04:52
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #4646 (8245a45) into master (77e0672) will increase coverage by 0.17%.
The diff coverage is 94.77%.

@@            Coverage Diff             @@
##           master    #4646      +/-   ##
==========================================
+ Coverage   71.84%   72.02%   +0.17%     
==========================================
  Files         247      249       +2     
  Lines       26393    26646     +253     
  Branches     2792     2792              
==========================================
+ Hits        18962    19191     +229     
- Misses       6925     6949      +24     
  Partials      506      506              
Flag Coverage Δ
cube-backend 59.25% <ø> (ø)
cubesql 81.23% <94.77%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 91.66% <69.23%> (-1.23%) ⬇️
...besql/cubesql/src/compile/rewrite/rules/members.rs 98.33% <93.33%> (-0.68%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 75.48% <100.00%> (+0.18%) ⬆️
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 95.79% <100.00%> (-0.07%) ⬇️
...besql/cubesql/src/compile/rewrite/rules/filters.rs 92.50% <100.00%> (+0.64%) ⬆️
rust/cubesql/pg-srv/src/buffer.rs 67.04% <0.00%> (-0.78%) ⬇️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 53.34% <0.00%> (-0.38%) ⬇️
rust/cubesql/cubesql/src/sql/statement.rs 72.00% <0.00%> (-0.25%) ⬇️
rust/cubesql/pg-srv/src/protocol.rs 82.94% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e0672...8245a45. Read the comment docs.

@paveltiunov paveltiunov merged commit 3cbd753 into master Jun 2, 2022
@paveltiunov paveltiunov deleted the powerbi-contains branch June 2, 2022 05:58
@rpaik rpaik added the Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022 label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants