fix(cubesql): Don't show meta OLAP queries in query history #8336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
MazterQyou
force-pushed
the
cubesql/data-query-span
branch
from
0cee15b
to
61ba953
Compare
MazterQyou
changed the title
paveltiunov
approved these changes
Aug 28, 2024
MazterQyou
force-pushed
the
cubesql/data-query-span
branch
from
61ba953
to
662ff94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8336 +/- ##
==========================================
- Coverage 82.67% 82.61% -0.06%
==========================================
Files 217 217
Lines 78125 78215 +90
==========================================
+ Hits 64589 64619 +30
- Misses 13536 13596 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR changes the behavior of
isDataQueryflag, instead passing it asfalseby default onPreparestep, when query is parsed, and then passing the updated value only onExecutestep. This avoids duplicated entries in query history for the same query with, for instance, Tablaeu, which would parse the query and get its meta result first, then repeat the same steps, but next time execute the query.