Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cubesql): Add forgotten logger and pushdown check in test #8646

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

mcheshkov
Copy link
Member

No description provided.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 0:21am

@mcheshkov mcheshkov changed the title test(cubesql): Add forgotten logger init in test test(cubesql): Add forgotten logger and pushdown check in test Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (0959f7d) to head (2bf7b07).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8646   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         209      209           
  Lines       77049    77054    +5     
=======================================
+ Hits        63603    63608    +5     
  Misses      13446    13446           
Flag Coverage Δ
cubesql 82.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review August 29, 2024 09:26
@mcheshkov mcheshkov requested a review from a team as a code owner August 29, 2024 09:26
@mcheshkov mcheshkov merged commit 1f59072 into master Aug 29, 2024
65 checks passed
@mcheshkov mcheshkov deleted the test-coalesce-two-dimensions-logger branch August 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants