Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesqlplanner): Base joins support #8656

Merged
merged 26 commits into from
Sep 29, 2024
Merged

Conversation

waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 11:19am

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (ab3771b) to head (297499c).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8656      +/-   ##
==========================================
- Coverage   82.66%   82.66%   -0.01%     
==========================================
  Files         217      217              
  Lines       78125    78125              
==========================================
- Hits        64583    64580       -3     
- Misses      13542    13545       +3     
Flag Coverage Δ
cubesql 82.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waralexrom waralexrom marked this pull request as ready for review September 19, 2024 16:52
@waralexrom waralexrom requested review from a team as code owners September 19, 2024 16:52
@waralexrom waralexrom changed the base branch from sql-planner-filter-support to master September 19, 2024 16:52
@waralexrom waralexrom merged commit a2e604e into master Sep 29, 2024
69 checks passed
@waralexrom waralexrom deleted the sql-planner-joins-support branch September 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants