Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(cubesql): Attach cubenativeutils and cubesqlplanner to cargo fmt and cargo check #8677

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ci(cubesql): Attach cubenativeutils and cubesqlplanner to cargo fmt and cargo check #8677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ed8bc9
chore(cubesql): Align Rust toolchain in cubenativeutils and cubesqlpl…
mcheshkov Sep 6, 2024
268658e
chore(cubesql): Update Cargo.lock in cubenativeutils and cubesqlplanner
mcheshkov Sep 6, 2024
8433087
ci(cubesql): Attach cubenativeutils and cubesqlplanner to cargo fmt a…
mcheshkov Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/rust-cubesql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,21 @@ jobs:
shared-key: cubesql-${{ runner.OS }}-x86_64-unknown-linux-gnu
- name: Lint CubeSQL
run: cd rust/cubesql && cargo fmt --all -- --check
- name: Lint Native utils
run: cd rust/cubenativeutils && cargo fmt --all -- --check
- name: Lint SQL planner
run: cd rust/cubesqlplanner && cargo fmt --all -- --check
- name: Lint Native
run: cd packages/cubejs-backend-native && cargo fmt --all -- --check
# TODO replace with clippy once cubesql is ready
- name: Check CubeSQL
run: cd rust/cubesql && cargo check --locked --workspace --all-targets --keep-going
# TODO replace with clippy once cubenativeutils is ready
- name: Check Native utils
run: cd rust/cubenativeutils && cargo check --locked --workspace --all-targets --keep-going
# TODO replace with clippy once cubesqlplanner is ready
- name: Check SQL planner
run: cd rust/cubesqlplanner && cargo check --locked --workspace --all-targets --keep-going
- name: Clippy Native
run: cd packages/cubejs-backend-native && cargo clippy --locked --workspace --all-targets --keep-going -- -D warnings
- name: Clippy Native (with Python)
Expand Down
1 change: 0 additions & 1 deletion rust/cubenativeutils/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/cubenativeutils/rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[toolchain]
channel = "nightly-2023-12-13"
channel = "nightly-2024-07-15"
components = ["rustfmt", "rustc-dev", "clippy"]
profile = "minimal"
profile = "minimal"
1 change: 0 additions & 1 deletion rust/cubesqlplanner/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/cubesqlplanner/rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[toolchain]
channel = "nightly-2023-12-13"
channel = "nightly-2024-07-15"
components = ["rustfmt", "rustc-dev", "clippy"]
profile = "minimal"
profile = "minimal"
Loading