Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Pass null_equals_null through egraph #8776

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:50am

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (8e815c2) to head (f7b512f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8776      +/-   ##
==========================================
- Coverage   82.55%   82.54%   -0.01%     
==========================================
  Files         221      221              
  Lines       77703    77709       +6     
==========================================
  Hits        64146    64146              
- Misses      13557    13563       +6     
Flag Coverage Δ
cubesql 82.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review October 4, 2024 15:38
@mcheshkov mcheshkov requested a review from a team as a code owner October 4, 2024 15:38
@mcheshkov mcheshkov force-pushed the egraph-join-null-equals-null branch 2 times, most recently from 60aba1c to 9885871 Compare October 9, 2024 18:31
@mcheshkov mcheshkov force-pushed the egraph-join-null-equals-null branch 3 times, most recently from 44829a3 to bb35829 Compare October 17, 2024 16:16
@mcheshkov mcheshkov force-pushed the egraph-join-null-equals-null branch 2 times, most recently from 4644669 to 8fd1e71 Compare October 22, 2024 16:59
@mcheshkov mcheshkov merged commit e02f612 into master Nov 11, 2024
86 checks passed
@mcheshkov mcheshkov deleted the egraph-join-null-equals-null branch November 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant