Add aarch64-apple-darwin build target to cubestore #8950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
Yes, it's correct. |
|
LGTM, merged! Thank you @vieira for your contribution 🍰 🍥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Fixes #8949
Description of Changes Made
Add
aarch64-apple-darwinas a build target to thecubestorematrix and updategetTarget()to returnaarch64-apple-darwinto darwin on arm64 instead of returningx86_64-apple-darwinand requiring Rosetta 2.A previous attempt appears to have been made by @ovr on #2658 but seems to have been abandoned (perhaps because at the time GitHub actions did not have a ARM64 macOS runner? It was made available on Jan 2024).
I ran the workflow
rust-cubestore-master.yml, downloaded the artifact resulting from the new jobcubestore (aarch64-apple-darwin)to a macbook w/ arm64 and confirmed that #8949 is solved.I am not familiar with the build/release infrastructure of Cube. Please review and let me know if any changes should be made. Thanks!