Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Add folders to Cube Metadata #9089

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix(cubesql): Add folders to Cube Metadata #9089

merged 1 commit into from
Jan 11, 2025

Conversation

max-kammerer
Copy link
Member

No description provided.

@max-kammerer max-kammerer requested review from a team as code owners January 10, 2025 15:14
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (d8d8de2) to head (1994dcb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubeclient/src/models/v1_cube_meta_folder.rs 0.00% 4 Missing ⚠️
rust/cubesql/cubeclient/src/models/v1_cube_meta.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9089      +/-   ##
==========================================
+ Coverage   82.75%   82.85%   +0.09%     
==========================================
  Files         221      222       +1     
  Lines       78814    78828      +14     
==========================================
+ Hits        65220    65309      +89     
+ Misses      13594    13519      -75     
Flag Coverage Δ
cubesql 82.85% <64.28%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@max-kammerer max-kammerer merged commit 8d714d6 into master Jan 11, 2025
67 of 68 checks passed
@max-kammerer max-kammerer deleted the mb/folders branch January 11, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants