Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve support for Timestamp DT #33

Open
wants to merge 2 commits into
base: cube-main
Choose a base branch
from

Conversation

ovr
Copy link
Member

@ovr ovr commented Mar 21, 2023

Hello!

Thanks

@coveralls
Copy link

coveralls commented Mar 21, 2023

Pull Request Test Coverage Report for Build 4479158152

  • 30 of 42 (71.43%) changed or added relevant lines in 5 files are covered.
  • 53 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-6.9%) to 82.306%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 0 1 0.0%
src/parser.rs 9 14 64.29%
src/ast/data_type.rs 7 13 53.85%
Files with Coverage Reduction New Missed Lines %
src/ast/data_type.rs 1 68.09%
src/ast/mod.rs 2 70.48%
src/ast/query.rs 2 85.07%
tests/sqlparser_snowflake.rs 2 96.43%
src/parser.rs 4 84.25%
tests/sqlparser_postgres.rs 8 97.06%
tests/sqlparser_common.rs 34 97.19%
Totals Coverage Status
Change from base Build 1513769481: -6.9%
Covered Lines: 5610
Relevant Lines: 6816

💛 - Coveralls

…s preserved (apache#641)

* 640 Fixing time zone printing format for TIMESTAMP and TIME

* 640 Removing unnecessary changes

* Update src/ast/data_type.rs

Fix comment typo

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants