Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support placeholders in OFFSET, FETCH ... #44

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

MazterQyou
Copy link
Member

This PR adds support for placeholders in OFFSET, FETCH ... by patching parse_number_value to accept placeholders; previous solution only explicitly accounted for LIMIT. Related tests are included.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8024990616

Details

  • 0 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.483%

Totals Coverage Status
Change from base Build 7904820459: 0.01%
Covered Lines: 8993
Relevant Lines: 10050

💛 - Coveralls

@MazterQyou MazterQyou merged commit 347f769 into cubesql-v0.16.0 Feb 23, 2024
18 checks passed
@MazterQyou MazterQyou deleted the cubesql-offset-fetch-placeholder branch February 23, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants