Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PERCENTILE_CONT function support #45

Open
wants to merge 2 commits into
base: cubesql-v0.16.0
Choose a base branch
from

Conversation

MazterQyou
Copy link
Member

This PR adds support for PERCENTILE_CONT(...) WITHIN GROUP (ORDER BY ...) parsing support. Related test is included.

@KSDaemon
Copy link
Member

Do we need to support array versions of the percentile_cont?

percentile_cont ( fractions double precision[] ) WITHIN GROUP ( ORDER BY double precision ) → double precision[]
percentile_cont ( fractions double precision[] ) WITHIN GROUP ( ORDER BY interval ) → interval[]

@MazterQyou
Copy link
Member Author

Do we need to support array versions of the percentile_cont?

percentile_cont ( fractions double precision[] ) WITHIN GROUP ( ORDER BY double precision ) → double precision[]
percentile_cont ( fractions double precision[] ) WITHIN GROUP ( ORDER BY interval ) → interval[]

Unlikely. We're only supporting parsing and planning of this, presumably to push it down, and many data warehouses don't seem to support that.

@MazterQyou MazterQyou force-pushed the cubesql-percentile-cont branch 2 times, most recently from 39322c8 to f1a97af Compare August 14, 2024 15:44
@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10704099334

Details

  • 61 of 66 (92.42%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.529%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 27 29 93.1%
src/ast/mod.rs 10 13 76.92%
Totals Coverage Status
Change from base Build 8079365665: 0.03%
Covered Lines: 9063
Relevant Lines: 10123

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants