Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounded corners #45

Closed
wants to merge 1 commit into from
Closed

Conversation

isaacvr
Copy link

@isaacvr isaacvr commented Sep 25, 2024

Now the puzzle have a better user interface by adding some roundness to the corners.

@mfeather1
Copy link
Collaborator

Thank you for your contribution showing how to implement rounded corners with bezier curve, we are reviewing it.

@bcube2
Copy link
Collaborator

bcube2 commented Sep 30, 2024

Thank you for your pull request. There are some issues with your submitted code, such as:

  1. it seems to be not working correctly with the hint and supercube parameters
  2. there is no option to specify which corners get rounded

As it turned out, these can be fixed. We do think it is a nice and elegant enhancement, so we added it to the Enhancement section of the AnimCubeJS documentation page (check it out here with a simplified code).

If there is a convenient programming way (which I don´t see) for adjusting roundness and specifying which corners get rounded by non-programmers via parameters (default being no roundness for all corners), I would certainly support implementing it to all 2x2x2 - 7x7x7 programs.

@bcube2 bcube2 closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants