-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3x3 + OH + BLD Relay and Team Factory icons #109
Conversation
I figured it made more sense to include the non-team version of 3x3 + OH + BLD relay icon too, since that's the less specific case, and then the team version simply builds on that icon, using the exact same 3 circles as in 3x3 BLD 3-man relay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team factory and team bld look good to me.
The relay icons look quite crowded to me, but I don't actually have a suggestion for fixing them.
Approved from my perspective, but I'd like to hear from another maintainer (@lgarron?) before merging.
I just went with the same idea as Mini guildford. I actually think it looks alright, because it's quite clear what it represents. |
One option is to replace the OH cube with a single square, same as Mini Guildford does it |
@jfly I have made the aforementioned change, now it's the same as in Mini Guildford: |
I would appreciate having a new NPM package version once this PR is merged. I would like to use all of the new icons. |
I'll merge this (and do an npm release) early next week unless another maintainer gives feedback before then. |
@jfly Could you deploy this today? I would like to add the new icons to my website :) |
I'll merge this tomorrow morning unless someone chimes in before then. @lgarron last chance for feedback! (of course, we can always change these things in the future if want) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to find a better way to combine separate icons (maybe a cartouche?) at some point, but these look good to me for now!
@dmint789 version 1.0.9 (https://github.com/cubing/icons/releases/tag/v1.0.9) of @cubing/icons has been released to npm. |
@jfly thank you! I've already updated my package :) |
Did we not want to use underscores before releasing? |
What are underscores? |
Ahh sorry, I thought we were talking about release naming conventions or something. Let's continue the discussion about naming conventions over on #108 |
This PR makes the following changes:
Add 3x3 + OH + BLD Relay icon (
333-oh-bld-relay
)Add 3x3 + OH + BLD Team Relay icon (
333-oh-bld-team-relay
)Add 3x3 Team Factory icon (
333-team-factory
). Similar idea to the Team-Blind icon.Slightly tweak Team-Blind icon, making the circles a little smaller. The circles are consistent between Team Factory and Team Blind.
Previews:
This solves part of #105