Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unofficial events to use underscores instead of dashes. #111

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lgarron
Copy link
Member

@lgarron lgarron commented Sep 12, 2023

Per discussion in #108 as well as several PRs and issues.

Per discussion in #108 as well as several PRs and issues.
Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgarron lgarron merged commit 5cd757b into main Sep 12, 2023
1 check passed
@lgarron lgarron deleted the lgarron/underscores branch September 12, 2023 20:38
@lgarron
Copy link
Member Author

lgarron commented Sep 13, 2023

@jfly You okay with releasing a v1.1.0 bump before #112 ?

@jfly
Copy link
Member

jfly commented Sep 14, 2023

That seems fine to me!

@lgarron
Copy link
Member Author

lgarron commented Sep 14, 2023

Released and published to https://cdn.cubing.net/css/@cubing/icons !

@dmint789
Copy link
Contributor

Oh, I just now noticed you guys did this. Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants