Add new icons: 2x2x2 OH, Mirror Blocks Blindfolded, 4x4x4 With Feet #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfly we've actually combined forces with the unofficial events stuff, and the naming is exactly the same as on our cubingcontests.com website, so you can just go ahead with the merge. We'll also likely be moving this project to the cubing organization in the near future. |
lgarron
reviewed
Oct 30, 2023
Let's have a separate conversation about that someday? I'm not immediately thrilled about that: I personally have never worked on project that requires more than 1 person (besides the contributor) to approve every change. |
|
I agree, I feel like requiring multiple reviews for such a small project is too much. Maybe we could just give 24 hours for people to leave their thoughts in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.