Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit icons: 3x3/OH/BLD Relay and Team Relay, 3x3 BLD 4/8-man Relay and Mini Guildford #118

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

dmint789
Copy link
Contributor

@dmint789 dmint789 commented Oct 30, 2023

This PR edits the following icons:

  1. Mini Guildford
  2. 3x3 BLD 4-man Relay
  3. 3x3 BLD 8-man Relay
  4. 3x3 + OH + BLD Relay
  5. 3x3 + OH + BLD Team Relay

All changes except Mini Guildford are simple tweaks based on actually using the new icons. Mini Guildford includes the following changes:

  • Reposition the elements to respect padding
  • Make the OH event consistent with the 333oh icon
  • Use the Clock's handle, since it doesn't add too much detail, while making it clear this is the Clock event

Preview:

minigf

Related to issue #110

svgs/unofficial/333_oh_bld_relay.svg Show resolved Hide resolved
@dmint789 dmint789 closed this Oct 30, 2023
@dmint789 dmint789 reopened this Oct 30, 2023
@dmint789
Copy link
Contributor Author

Oops, I accidentally closed this while trying to merge (forgetting that I don't have the rights). @jfly can you merge this?

@jfly jfly merged commit eb1f89c into cubing:main Oct 30, 2023
2 checks passed
@dmint789
Copy link
Contributor Author

@jfly could you also please deploy this? 🙏

@jfly
Copy link
Member

jfly commented Oct 30, 2023

@dmint789, we don't really deploy this anywhere. Are you asking for me to do a release?

@dmint789
Copy link
Contributor Author

@jfly I meant release, yeah, my bad

@jfly
Copy link
Member

jfly commented Oct 30, 2023

@dmint789 v1.1.1 is released: https://www.npmjs.com/package/@cubing/icons/v/1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants