Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info file with lists of all available icons #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmint789
Copy link
Contributor

I really need something like this, where I can easily get a list of all available official icons and unofficial icons. This does mean that with each new icon added this file will need to be updated with a new line, but new icons aren't added very often at all, so I don't think this is a big deal. If someone has a better idea to be able to do the same thing, I'm happy to hear.

Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really need something like this, where I can easily get a list of all available official icons and unofficial icons

Can you elaborate on this? I'm not opposed to this, but it would be nice for the commit message to explain the reasoning in a bit more detail.

but new icons aren't added very often at all, so I don't think this is a big deal

I am opposed to hardcoding this list, though. IMO, the fact that this stuff changes infrequently actually makes it even more important to automate this (because we don't do it frequently enough to remember there's this other thing you have to Just Remember to do).

I'd tell you to do this as part of the gulp pipeline, but that's possibly going away entirely, see #112. @lgarron, are you motivated to push #112 over the finish line?

@dmint789
Copy link
Contributor Author

Yeah, so the reason is that it's easier when you can immediately tell if an icon for a given ID exists. So far I've just been maintaining this exact same list on my end, and it's very annoying. I do agree that having this done automatically would be better though.

@jfly
Copy link
Member

jfly commented Oct 30, 2023

Yeah, so the reason is that it's easier when you can immediately tell if an icon for a given ID exists

Who is "you" here? @dmint789 the human? Or some code you've written?

I think there are already a number of easy ways for a human to find what icons exist. An incomplete list:

  1. ctrl+f on https://icons.cubing.net/
  2. clone this repo, run a command like git ls-files | grep 333oh

@dmint789
Copy link
Contributor Author

@jfly I meant my code. The code needs to know when to display an svg and when to display a fallback button if the icon is missing.

@jfly
Copy link
Member

jfly commented Oct 30, 2023

The code needs to know when to display an svg and when to display a fallback button if the icon is missing.

Awesome. This is the sentence missing from your commit message.

@dmint789
Copy link
Contributor Author

@jfly ok. I guess I can change that once we figure out how to automate this.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 1, 2024

@jfly do you have ideas on how we could automate the generation of a file like this in the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants