Add link about migration to Cubing Contests & fix two inconsistencies in the results #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmint789
commented
Nov 16, 2023
dmint789
commented
- Replace the link to submit more results with a link to Cubing Contests with a message mentioning that the project has migrated.
- Fix round format for Mirror Blocks at Munich Open 2010 to match the order of the results.
- Reverse the rounds for Mirror Blocks at Kanazawa Open 2008. It is assumed that they were in the original order by mistake, since round 1 had half the number of people in finals, and it was Ao5, while finals was Bo2, which makes little sense.
…ce the link for sending in results with a link to Cubing Contests.
lgarron
reviewed
Nov 16, 2023
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "formatter": { | |||
| "indentStyle": "space", | |||
| "indentSize": 2, | |||
| "indentWidth": 2, | |||
There was a problem hiding this comment.
Hmm, this shouldn't be causing a linter issue, but worth doing anyhow. I'll do that in a separate commit.
There was a problem hiding this comment.
It threw an error before, so I thought I'd try to fix it
There was a problem hiding this comment.
Should I undo this?
There was a problem hiding this comment.
Actually, it looks like we can't switch to this yet, Biome is still in the process of switching.
There was a problem hiding this comment.
Hmm, okay, I've made indentWidth work now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.