Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin posting to front page #206

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jpbulman
Copy link
Member

@jpbulman jpbulman commented Feb 13, 2019

(Sorry about having the personnel updates in here, I created a new branch while having checked that one out, so it brought these with it) @timreyn What is the best way to go about adding the announcements to the datastore. should I make a separate handler, similar to this?

<li class="list-group-item">Regional Championships Announced! <a href="cubingusa.org">Read More</a></li>
<li class="list-group-item">Make sure to check out our new logo!</li>
</ul>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look? I have it set up so it's different from the 'more links' card because it seems more important. I have the layout for making it a normal card header commented out for now. Do people want this to look different, or have it the same as the 'more links' style?


<!-- Example posts for now -->
<ul class="list-group">
<li class="list-group-item">Posts will appear here <i class="fa fa-trash float-right"></i> <i class="fa fa-edit float-right"></i></li>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FA icons need some formatting, they're there just as placeholders


<h1>CubingUSA Announcements</h1>

<div style="margin-top:30px;">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this kind of inline CSS okay, or should I make a separate style file for the announcements?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not have inline styling. As the project grows it will only get harder to move the inline styling out into separate files.

@jpbulman
Copy link
Member Author

jpbulman commented Mar 3, 2019

Anyone have thoughts on this?

@ToastyKen
Copy link
Contributor

Can you provide a staging link or screenshot?

@ToastyKen ToastyKen requested review from timreyn and ToastyKen March 14, 2019 03:09
@FatBoyXPC FatBoyXPC changed the base branch from master to linkify-who March 14, 2019 04:24
@FatBoyXPC FatBoyXPC changed the base branch from linkify-who to master March 14, 2019 04:24
@FatBoyXPC
Copy link
Member

FatBoyXPC commented Mar 14, 2019

I toggled the base branch to make the extra commits disappear since they were already merged into master. In the future, if you'd like to learn how to remove the unnecessary commits, hit me up and I can screenshare and show you a couple different techniques.

I agree with @ToastyKen, I'd like to see some screenshots as well!

@jpbulman
Copy link
Member Author

Hey all,

Sorry about the delay in this, classes really made me lose track of time at the end of the semester. Anyways, now I'll have a lot more time to fiddle with this. Since it seemed a bit much to set up staging for style choices, I added a folder to the webmaster google drive and put the pictures there. Which do people like better? Personally, I think the default list without the card style (the list.png picture) would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants