This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Office window get closed too soon and/or must not be closed automatically in interactive mode. #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing Office window should be only in automated mode. Closing Office must not occur during the first run of the loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing Office window should be only in automated mode.
Closing Office must not occur during the first run of the loop.
What I have added/changed is:
Behavior of human.py auxiliary module
The goal of my change is:
Do not close Office window during the first run of the loop in human.py
Do not close Office window in real human interactive mode
What I have tested about my change is:
Behavior in "real human" and "automated human" analysis mode
A better improvement would be to use a relative delay matching with XX% of the analysis timeout.