This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Add ability to configure if you want proc memdumps from zer0m0n #3145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html
What I have added/changed is:
Create process memory dumps only if the desire is there (aka it's specified explicitly in
self.analyzer.config.options
asprocmemdump=1
).The goal of my change is:
If you do not explicitly want process memory dumps, you shouldn't have to deal with the additional processing time of uploading .dmp files or the inflated size of the cuckoo tar ball post-analysis. This configuration option is already used here:
cuckoo/cuckoo/data/analyzer/windows/analyzer.py
Line 338 in 073c5aa
dump_memory
is called.What I have tested about my change is:
Manual testing to ensure correct functionality.