Introduce Cucumber parameter type 'command' #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce Cucumber parameter type 'command' and use it
Details
This introduces a new Cucumber parameter type 'command', matching a string between backticks. It then uses this new parameter types to replace the old regular expression based step definitions. This allows more steps to use the Cucumber Expression syntax.
It also removes the need for python to be installed on of the scenarios that uses these step definitions, to ensure they're properly tested.
Motivation and Context
While working on #894, I noticed that the steps matching output from a particular command could not match against a command including quote characters. This change will make it easier to add an extra step definition to support that case. Update: It turns out matching is possible by using
\
. The present change is still an improvement, however.How Has This Been Tested?
I ran the relevant scenarios with the updated step definitions.
Types of changes
Checklist:
N/A