put leading new lines in shellrc additions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this ensures no line concatenation if there is a missing newline at the end of the file
|
What exactly is the bug this PR fixing? |
cultureamp-brucew
approved these changes
Jan 25, 2024
jay-aye-see-kay
deleted the
jdr/FEF-1009-leading-new-lines-in-shellrc-additions
branch
Updated PR to include bug description from ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug experienced by one developer during onboarding with team Survey Reporting where the last line of existing config was concatenated because there was a missing newline at the end of the file.
I tried to add a test to ensure the newline was put there but couldn't get it working with
assert_output --partialorassert_output --regexp. I can see in the test failures that the newline is actually there, it just doesn't seem to want to do a multi-line match.https://cultureamp.atlassian.net/browse/FEF-1009