Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jmx script to run_debezium wrapper script [DASE-1982] #41

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

m-dwyer
Copy link
Contributor

@m-dwyer m-dwyer commented Aug 26, 2024

Context

We are missing JMX support from the run_debezium wrapper script as part of our debezium-server nix package. This changes the wrapper script to source the required JMX script, so JMX is enabled if JMX_HOST and JMX_PORT are provided

Changes

  • Source the jmx_enable.sh bash script

@m-dwyer m-dwyer marked this pull request as ready for review August 26, 2024 07:51
Copy link
Member

@t-monaghan t-monaghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I only have one small style recommendation.

packages/debezium-server.nix Outdated Show resolved Hide resolved
@t-monaghan t-monaghan merged commit 2b5f86e into main Aug 28, 2024
8 checks passed
@t-monaghan t-monaghan deleted the DASE-1982/improve-debezium-package branch August 28, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants