fix: add xs margin top to the top of input #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0581f7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Comment on lines
5
to
8
|
|
||
| input { | ||
| margin-top: $spacing-xs; | ||
| } |
There was a problem hiding this comment.
As opposed to selecting input, create a new class and attach it to the Input instead.
I dived in a little more and realised TextField (I thought it could be used in DateInput, but it seems the icon prevents it from doing so, so sadly can't be done) also has the same issue.
Could you possibly fix the spacing there too? 🙏🏻
There was a problem hiding this comment.
Thanks @HeartSquared, that has been updated now.
HeartSquared
reviewed
Sep 1, 2023
packages/date-picker/src/_subcomponents/DateInput/DateInput.module.scss
Outdated
Show resolved
Hide resolved
packages/date-picker/src/DateRangePicker/DateRangePicker.module.scss
Outdated
Show resolved
Hide resolved
draft-packages/form/KaizenDraft/Form/TextField/TextField.module.scss
Outdated
Show resolved
Hide resolved
…dule.scss Co-authored-by: Cassandra <[email protected]>
…e.scss Co-authored-by: Cassandra <[email protected]>
…e.scss Co-authored-by: Cassandra <[email protected]>
|
@HeartSquared no problem, that's been updated now. |
HeartSquared
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR adds margin top to the top of the button for
DateRangePickerand top of the input forDateInput.This change makes the spacing consistent with labels from other components.
What
DateRangePicker Before (Notice the spacing below "Date range", compared to "Select report")
DateRangePicker After
DateInput Before
DateInput After
