Add classNameOverride to MultiSelectOption #21
Conversation
🦋 Changeset detectedLatest commit: 5d803a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kaydwithers
changed the title
|
Sorry @kaydwithers we shouldn't be adding styles specifically to fix Murmur, since we can't check if all the other products won't break. You'll have to resolve this on your side. |
|
@gyfchong I've updated the PR so that I can add classNameOverride to the component that I need to add content-box to. |
| import { Icon } from "@kaizen/component-library" | ||
| import check from "@kaizen/component-library/icons/check.icon.svg" | ||
| import { Badge } from "@kaizen/draft-badge" | ||
| import { MultiSelectItem } from "../../../types" | ||
| import { useSelectionContext } from "../../provider" | ||
| import styles from "./MultiSelectOption.module.scss" | ||
|
|
||
| export interface MultiSelectOptionProps { | ||
| export interface MultiSelectOptionProps | ||
| extends OverrideClassName<HTMLAttributes<HTMLSpanElement>> { |
There was a problem hiding this comment.
You've also added native attributes to the props API but it's not implemented in the component. Let's just remove that part because it's going to add complications to this PR.
There was a problem hiding this comment.
Thanks @dougmacknz , that's done now.
|
I'll get you to update the PR title as well plz 🙏 |
kaydwithers
changed the title
dougmacknz
changed the title
Why
This PR adds classNameOverride to the MultiSelectOption.
In Murmur the icon was not displaying correctly due to the reset.scss file using
box-sizing: border-box;addingbox-sizing: content-box;to the icon resolves this issue in Murmur.With classNameOverride added I can now add a Tailwind
box-contentclass.Fixes REP-597.
What
Before
After
