Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set disabled prop on Select label. #27

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

brandonwinch
Copy link
Contributor

Why

When the Select component is disabled, the label for the component doesn't change colour. This PR aims to fix that.

What

Screenshot of how it looks now:
Screenshot 2023-09-08 at 1 01 31 pm

@brandonwinch brandonwinch requested a review from a team as a code owner September 8, 2023 03:02
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

🦋 Changeset detected

Latest commit: 2ebc24a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HeartSquared HeartSquared enabled auto-merge (squash) September 8, 2023 03:07
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

✨ Here is your branch preview! ✨

Last updated for commit 2ebc24a: feat: set disabled prop on Select label

@HeartSquared HeartSquared merged commit 1d5f879 into main Sep 8, 2023
20 of 21 checks passed
@HeartSquared HeartSquared deleted the bwinch/set-select-label-disabled branch September 8, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants